Use Rust 2024, bump MSRV to 1.85 #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
hi @liclac thanks for this! can you rebase on master and force push here? I'd like to release a new (breaking) scroll with the rust 2024 bump |
Contributor
Author
|
@m4b Done :) |
Contributor
Author
|
...and another go, looks like updating the edition changed rustfmt's behaviour slightly. |
Owner
|
Thank you! I will try to cut a release tonight |
Owner
|
@liclac i'd like the other open PR to get merged before releasing a new crates.io, are you ok to wait a bit? if you feel like taking over that PR and rebasing/fixing it too if other author doesn't respond soon, go for it. |
Contributor
Author
|
No worries at all, I'm happy to just use my patched version for now. I'll have a look at the other PR when I have some free time. ^^
…On Mon, 19 May 2025, at 08:35, m4b wrote:
*m4b* left a comment (m4b/scroll#115) <#115 (comment)>
@liclac <https://github.com/liclac> i'd like the other open PR to get merged before releasing a new crates.io, are you ok to wait a bit? if you feel like taking over that PR and rebasing/fixing it too if other author doesn't respond soon, go for it.
—
Reply to this email directly, view it on GitHub <#115 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADIP6V5CLZLVWLF4AYCUJ327F3SFAVCNFSM6AAAAAB4LWVR7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBZG44DKNRWG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed in #111, so I figured I'd do this too while I was at it.