Made Try{From|Into}Ctx impl on CStr safe.
#104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Contributor
Author
|
I think we discussed this previously, but the library feature we're using, requires an MSRV of 1.69. |
m4b
requested changes
Oct 25, 2024
Owner
m4b
left a comment
m4b
left a comment
There was a problem hiding this comment.
Apologies for the delay, and thanks for adding this; especially the try_into_ctx change is quite nice.
However, the MSRV needs to be updated in order for CI to pass, unfortunately.
Would you mind adding that to this change and then we can merge?
Owner
|
@Frostie314159 i think we can safely add this now since we are updating to rust 2024 for the new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, I replaced the unsafe
from_bytes_with_nul_unchecked, withfrom_bytes_until_nuland simplified the writing.