[TorchToArith] Implement conversion for AtenNegFloatOp.
#4397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junru-Sheng
force-pushed
the
negOp
branch
4 times, most recently
from
3fe55f2 to
ed25af1
Compare
Collaborator
|
Why not add |
…ConvertAtenUnaryOpToFloatMathOp` to `ConvertAtenUnaryOp`. Implement conversion patterns for `AtenNegFloatOp`. Rename `ConvertAtenUnaryOpToFloatMathOp` to `ConvertAtenUnaryOp`. Add test case for `ConvertAtenNegIntOp`.
Junru-Sheng
changed the title
AtenNegFloatOp.AtenNegFloatOp.
Contributor
Author
|
@zjgarvey Nice! I followed your suggestion and updated the code. Please review them again? |
CoTinker
approved these changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement conversion patterns for
AtenNegFloatOp.And use unified template patterns
ConvertAtenNegOpto handleAtenNegIntOp,AtenNegFloatOp.