Skip to content

[lldb][NFCI] Remove unused field in BreakpointResolverName #172574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bulbazord merged 1 commit into from
Dec 17, 2025
+5 −13
Merged

[lldb][NFCI] Remove unused field in BreakpointResolverName #172574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lldb/include/lldb/Breakpoint/BreakpointResolverName.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ class BreakpointResolverName : public BreakpointResolver {
BreakpointResolverName(const BreakpointResolverName &rhs);

std::vector<Module::LookupInfo> m_lookups;
ConstString m_class_name;
RegularExpression m_regex;
Breakpoint::MatchType m_match_type;
lldb::LanguageType m_language;
Expand Down
17 changes: 5 additions & 12 deletions lldb/source/Breakpoint/BreakpointResolverName.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,17 +76,16 @@ BreakpointResolverName::BreakpointResolverName(const BreakpointSP &bkpt,
lldb::addr_t offset,
bool skip_prologue)
: BreakpointResolver(bkpt, BreakpointResolver::NameResolver, offset),
m_class_name(nullptr), m_regex(std::move(func_regex)),
m_match_type(Breakpoint::Regexp), m_language(language),
m_skip_prologue(skip_prologue) {}
m_regex(std::move(func_regex)), m_match_type(Breakpoint::Regexp),
m_language(language), m_skip_prologue(skip_prologue) {}

BreakpointResolverName::BreakpointResolverName(
const BreakpointResolverName &rhs)
: BreakpointResolver(rhs.GetBreakpoint(), BreakpointResolver::NameResolver,
rhs.GetOffset(), rhs.GetOffsetIsInsnCount()),
m_lookups(rhs.m_lookups), m_class_name(rhs.m_class_name),
m_regex(rhs.m_regex), m_match_type(rhs.m_match_type),
m_language(rhs.m_language), m_skip_prologue(rhs.m_skip_prologue) {}
m_lookups(rhs.m_lookups), m_regex(rhs.m_regex),
m_match_type(rhs.m_match_type), m_language(rhs.m_language),
m_skip_prologue(rhs.m_skip_prologue) {}

BreakpointResolverSP BreakpointResolverName::CreateFromStructuredData(
const StructuredData::Dictionary &options_dict, Status &error) {
Expand Down Expand Up @@ -258,12 +257,6 @@ BreakpointResolverName::SearchCallback(SearchFilter &filter,
SymbolContext &context, Address *addr) {
Log *log = GetLog(LLDBLog::Breakpoints);

if (m_class_name) {
if (log)
log->Warning("Class/method function specification not supported yet.\n");
return Searcher::eCallbackReturnStop;
}

SymbolContextList func_list;
bool filter_by_cu =
(filter.GetFilterRequiredItems() & eSymbolContextCompUnit) != 0;
Expand Down
Loading