Skip to content

Conversation

@makslevental
Copy link
Contributor

@makslevental makslevental commented Dec 6, 2025

This PR factors out the LLVM distro portion of the build of mlir-python-bindings-wasm - i.e., it creates a wasm32-empscripten wheel/distro in addition to our current set of platforms. This is in preparation for #268 which will build out various mlir-wgpu things on top of this distro.

One tedious/weeds thing to call out: just building the distro via cross-compiling (using Emscripten's toolchain) didn't work because find_package(Python3 Development) fails to successfully find Python dev libs. I believe it has something to do with CMP0190 but I couldn't debug it all the way. But pyodide build succeeds (because it somehow isn't cross-compiling technically???) so that's good enough.

In addition some drive-by cleanup (remove macos-13 from the GHA workflows).

@makslevental makslevental force-pushed the users/makslevental/enable-wasm-llvm branch 5 times, most recently from 736e8a4 to d243037 Compare December 7, 2025 00:08
@makslevental makslevental force-pushed the users/makslevental/enable-wasm-llvm branch 11 times, most recently from a6b71f6 to 7803709 Compare December 7, 2025 05:22
@makslevental makslevental force-pushed the users/makslevental/enable-wasm-llvm branch from 7803709 to dcd514f Compare December 7, 2025 05:36
@makslevental makslevental marked this pull request as ready for review December 7, 2025 05:38
@makslevental makslevental force-pushed the users/makslevental/enable-wasm-llvm branch from dcd514f to 1002be5 Compare December 7, 2025 05:42
Copy link
Contributor

@ashermancinelli ashermancinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@makslevental makslevental force-pushed the users/makslevental/enable-wasm-llvm branch 4 times, most recently from 33c1453 to 11063f6 Compare December 7, 2025 05:46
@makslevental makslevental force-pushed the users/makslevental/enable-wasm-llvm branch from 11063f6 to db994ac Compare December 7, 2025 06:30
@makslevental makslevental force-pushed the users/makslevental/enable-wasm-llvm branch 3 times, most recently from 8d6810e to 6cbbc3c Compare December 7, 2025 07:02
@makslevental makslevental force-pushed the users/makslevental/enable-wasm-llvm branch from 6cbbc3c to dca4f85 Compare December 7, 2025 07:05
@makslevental makslevental force-pushed the users/makslevental/enable-wasm-llvm branch from da0b9c2 to ec0712d Compare December 7, 2025 08:39
@makslevental makslevental merged commit 90e277b into main Dec 7, 2025
186 checks passed
@makslevental makslevental deleted the users/makslevental/enable-wasm-llvm branch December 7, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants