-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
bugSomething isn't workingSomething isn't workingcontributionFor reporting bugs, issues, or suggestions intended to improve the project.For reporting bugs, issues, or suggestions intended to improve the project.good first issueGood for newcomersGood for newcomersrefactorImprove code quality without changing behaviorImprove code quality without changing behavior
Description
In BiasLabel and UXCoreLines, the label positions in the 3rd section are not correct.
Right now, it looks okay, mostly because SCSS is masking it, but the geometry logic is not fully correct under the hood. The root cause is likely in getLeftEndOfPath.
Important Notes:
- In
CoreViewLayout, this is the 3rd section in the sequence. - In
UXCoreLines, it may appear as the 4th, because SVG sequencing is different. - To keep things clear, we will call it “26 lines section”.
- This is the only section that has 26 lines (others have 25).
Suspicious area
getLeftEndOfPathcurrently handles both the 3rd and 4th section logic.- There’s an exception
if/elsespecifically for the 26 lines section. - That exception should be removed once the geometry logic is fixed.
Cleanup required after fix
- Remove the special-case logic for the 26 lines section inside
getLeftEndOfPath. - Remove the SCSS workaround in
BiasLabel.module.scss(line ~80).
Expected result
- Label positions are correct without SCSS hacks.
- No special
if/elsecase geometry logic for the 26 lines section. - By default, other labels use: transform: translate(5px, -50%);
- This should be the maximum horizontal offset any label needs.
- If the left label in the 26 lines section still needs special handling, do it via a separate left-label rule/modifier (not extra hacks inside the main rule).
- Use one SCSS rule for all labels.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingcontributionFor reporting bugs, issues, or suggestions intended to improve the project.For reporting bugs, issues, or suggestions intended to improve the project.good first issueGood for newcomersGood for newcomersrefactorImprove code quality without changing behaviorImprove code quality without changing behavior