Skip to content

DMD-375 add new suite paratest-snowflake-real-storage #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zajca wants to merge 4,878 commits into
base: master
Choose a base branch
from
Open

DMD-375 add new suite paratest-snowflake-real-storage #1569

zajca wants to merge 4,878 commits into from

Conversation

@zajca
Copy link
Member

@zajca zajca commented Sep 16, 2025 •
edited
Loading

Jira: DMD-375
KBC: https://github.com/keboola/connection/pull/6203

Before asking for review make sure that:

Checklist

  • New client method(s) has tests
  • New client method(s) support branches, or they are listed in BranchAwareClient
  • Apiary file is updated

Release

  • I gave the PR a proper label:
    • major (BC break)
    • minor (new feature)
    • patch (backwards compatible fix)
    • no release (just test changes)

jirkasemmler and others added 30 commits March 31, 2025 15:40
@jirkasemmler
apiary
0f7ff97
@jirkasemmler
Merge pull request #1481 from keboola/jirka/ct-1955-delete-rows-in-bq…
8ef907e 
…-enable-tests
@romanbracinik
remove deprecated tests
9648660
@romanbracinik
Merge pull request #1482 from keboola/roman/dmd-64-move-share-to-proj…
a46f1c7 
…ects-to-symfonye2

remove deprecated tests
@zajca
add utils methods
6c92566
@zajca
WorkspaceConnectionTrait support key pair
a1ac599
@zajca
add support for snowflake-person-keypair
7c71d08
@zajca
add snowflake-person-keypair test
3529892
@zajca
add snowflake-service-keypair support
4147137
@zajca
Merge pull request #1483 from keboola/zajca/pat-178/ws-keypair
0f7524a 
PAT-178 ws keypair
@tomasfejfar
DMD-92 Throw meaningful exception when view is out of sync
6af4612
@tomasfejfar
Merge pull request #1486 from keboola/tf-DMD-92-sds-change-of-datastr…
51eda9c 
…ucture-should-not-cause-internal-error

DMD-92 Throw meaningful exception when view is out of sync
@tomasfejfar
DMD-108 fix test issue from DMD-92
0ad52c7
@tomasfejfar
Merge pull request #1491 from keboola/tf-DMD-108-fix-failing-tests-af…
8bc0ed5 
…ter-dmd-92

DMD-108 fix test issue from DMD-92
@romanbracinik
remove unused deprecated shareBucket method
61e1c3e
@romanbracinik
remove async from client
a45e336
@romanbracinik
Update tests
dd20f10
@romanbracinik
Baseline
ea1c0a9
@romanbracinik
update apiary
1580837
@zajca
Merge pull request #1492 from keboola/roman/dmd-103-remove-sync-optio…
2b2f565 
…n-for-sharing

Roman/dmd 103 remove sync option for sharing
@jirkasemmler
DMD-105 test IM from table in standard EB
8ea038e
@jirkasemmler
fix tests
65772c5
@jirkasemmler
styling
ea0a2d0
@jirkasemmler
Merge pull request #1490 from keboola/jirka/dmd-105-test-im-of-tables…
77e4f99 
…-from-standard-external-buckets

DMD-105 test im of tables from standard external buckets
@zajca
PAT-178 string codes improvements
b11abc0
@zajca
Merge pull request #1485 from keboola/zajca/pat-178/ws-keypair-refactor
b2cce76
@zajca
PAT-248 new test testWorkspaceKeyPairRotation
92c8f15
@zajca
PAT-248 new method setPublicKey
53d639d
@zajca
PAT-248 add api docs
1a6bdf4
@zajca
Merge pull request #1495 from keboola/zajca/pat-248/ws-keypair-rotation
1a7c6e1
@github-actions github-actions bot removed the tag-e2e label Sep 16, 2025
@github-actions
Copy link

github-actions bot commented Sep 16, 2025

Created tag dev-test-1569-1.

@zajca zajca force-pushed the zajca/dmd-375/ro-storage-branches branch 3 times, most recently from 4518b92 to 76d3ae7 Compare September 16, 2025 12:35
@zajca zajca added the tag-e2e label Sep 16, 2025
@github-actions github-actions bot removed the tag-e2e label Sep 16, 2025
@github-actions
Copy link

github-actions bot commented Sep 16, 2025

Created tag test-1569-1.

@zajca zajca added the tag-e2e label Sep 16, 2025
@github-actions github-actions bot removed the tag-e2e label Sep 16, 2025
@github-actions
Copy link

github-actions bot commented Sep 16, 2025

Created tag test-1569-2.

@zajca zajca force-pushed the zajca/dmd-375/ro-storage-branches branch from 76d3ae7 to 1aced60 Compare September 16, 2025 12:42
@zajca zajca force-pushed the zajca/dmd-375/ro-storage-branches branch from f1d929a to 85217ad Compare September 17, 2025 05:14
jirkasemmler and others added 4 commits September 17, 2025 08:09
@jirkasemmler
Merge pull request #1571 from keboola/zajca/fix-dot
b0bfd6d 
fix messages assertions
@martinsifra
feat(table profiling): Token in response
b0da3fe 
- DMD-285
- "Profiled by" token in profiling response.
@martinsifra
feat(table profiling): Add "DataSizeTableMetric" for Snowflake
64ec00b 
- DMD-285
- Add metric test because there was no "DataSizeTableMetric" available for
  Snowflake before.
@martinsifra
feat(table profiling): Latest drivers with numeric statistics
4bb4d52 
- DMD-285
@zajca zajca requested a review from jirkasemmler September 19, 2025 13:54
@zajca zajca force-pushed the zajca/dmd-375/ro-storage-branches branch from e544e7b to 1371fc9 Compare September 19, 2025 13:55
jirkasemmler
jirkasemmler requested changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@jirkasemmler jirkasemmler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

malickost

phpunit.xml.dist
<directory>tests/Backend/NetworkPolicies</directory>
</testsuite>
<testsuite name="paratest-snowflake-storage-branches">
<directory>tests/Backend/Features/RealReadOnlyBranches</directory>
Copy link
Contributor

@jirkasemmler jirkasemmler Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to se mi libi, ze bychom to zacali trochu tridit podle features. Pri presunu do connection bychom v tom mohli udelat trochu vic poradek

tests/Backend/Features/RealReadOnlyBranches/SnowflakeRealBranchesTest.php Outdated
* @var array<array{name:string}> $schemas
*/
//@phpstan-ignore-next-line
$schemas = $wsBackend->getDb()->fetchAllAssociative('SHOW SCHEMAS WITH PRIVILEGES USAGE;');
Copy link
Contributor

@jirkasemmler jirkasemmler Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bez toho WITH PRIVILEGES USAGE by to funovalo?

Copy link
Member Author

@zajca zajca Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jop odstranil sem není potřeba to omezovat na práva

tests/Backend/Features/RealReadOnlyBranches/SnowflakeRealBranchesTest.php Outdated
* 3. Assert backendPath for both buckets.
* 4. Create workspace in default branch – ensure dev bucket NOT visible.
* 5. Create workspace in dev branch – ensure BOTH buckets visible.
* 6. Drop dev branch – ensure its bucket and workspace are deleted (no longer accessible).
Copy link
Contributor

@jirkasemmler jirkasemmler Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chybi mi tam jeden case - vyrabis a operujes nad devbranchi X. Ale co jina branch Y, ktera by nemela videt bucket z branche X? V bode 4 to testujes jen default - dev. Ale tam se krizi projektova RO role a dev RO role. Myslim, ze potrebujeme case dev-dev

Copy link
Member Author

@zajca zajca Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

přidáno

@zajca zajca force-pushed the zajca/dmd-375/ro-storage-branches branch from 1371fc9 to 4686520 Compare September 30, 2025 18:41
@zajca zajca requested a review from jirkasemmler September 30, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jirkasemmler jirkasemmler jirkasemmler approved these changes

Assignees

No one assigned

Labels

no release just test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@zajca @jirkasemmler @romanbracinik @tomasfejfar @pepamartinec @martinsifra @vojtabiberle @themark147