Port: add MACAddress field #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Winicius Silva <winiciusab12@gmail.com>
7 tasks
mandre
reviewed
Jan 2, 2026
Collaborator
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
Just a minor cleanup needed (we already set MAC address in the status) otherwise it's good to go. The additions to the tests is exactly how I would have done 👍
internal/controllers/port/status.go
Outdated
| WithUpdatedAt(metav1.NewTime(osResource.UpdatedAt)). | ||
| WithAdminStateUp(osResource.AdminStateUp) | ||
| WithAdminStateUp(osResource.AdminStateUp). | ||
| WithMACAddress(osResource.MACAddress) |
Collaborator
There was a problem hiding this comment.
We were already returning the MAC address in the status (line 64) so this change is not necessary.
Contributor
Author
There was a problem hiding this comment.
Done. I also noticed that I put in an extra writer for the AdminStateUp field in another PR. Fixed that too.
mandre
approved these changes
Jan 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the MACAddress field to the Port controller.
Partial: #616
Note: