Skip to content

Conversation

@tbhb
Copy link
Contributor

@tbhb tbhb commented Jan 2, 2026

Summary

  • Eliminate code duplication by having TableMixin.values() delegate to _sorted_records() instead of reimplementing the same list comprehension logic
  • Addresses review finding m1

Test plan

  • All existing tests pass (727 passed)

Eliminate code duplication by having TableMixin.values() call
_sorted_records() instead of reimplementing the same list
comprehension logic.
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 2, 2026

CodSpeed Performance Report

Merging #19 will improve performance by 17.65%

Comparing refactor/values-delegate-to-sorted-records (4c740e9) with main (e0ca4b4)1

Summary

⚡ 1 improvement
✅ 172 untouched

Benchmarks breakdown

Benchmark BASE HEAD Efficiency
test_find_all_records[small-int-1k] 3.7 ms 3.1 ms +17.65%

Footnotes

  1. No successful run was found on main (db493fb) during the generation of this report, so e0ca4b4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@tbhb tbhb merged commit c2fdff5 into main Jan 2, 2026
30 checks passed
@tbhb tbhb deleted the refactor/values-delegate-to-sorted-records branch January 2, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants