Update of the Section 3, ObsCore Attribute Definitions for High Energy Astrophysics Data
#16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I have a number of concerns with some of the changes proposed herein that I think we should discuss. We need to ensure that our proposed changes effect the existing approved ObsCore Recommendation. For example, having the proposed additional dataproduct_type definitions solely as vocabulary updates are not relevant to the current Recommendation since dataproduct_type is defined internally and not via a vocabulary. |
kosack
reviewed
Jul 29, 2025
kosack
suggested changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the section 3: