Add Test Framework for BootServer #248
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardikdr
force-pushed
the
enh/improve-bootserver-tests
branch
from
79263df to
9699701
Compare
hardikdr
force-pushed
the
enh/improve-bootserver-tests
branch
2 times, most recently
from
397c1ba to
20f7de9
Compare
hardikdr
force-pushed
the
enh/improve-bootserver-tests
branch
from
20f7de9 to
716d059
Compare
afritzler
requested changes
Dec 18, 2025
| var httpBootConfigs bootv1alpha1.HTTPBootConfigList | ||
| for _, ip := range clientIPs { | ||
| if err := k8sClient.List(ctx, &httpBootConfigs, client.MatchingFields{bootv1alpha1.SystemIPIndexKey: ip}); err != nil { | ||
| if err := k8sClient.List(ctx, &httpBootConfigs, client.MatchingFields{bootv1alpha1.NetworkIdentifierIndexKey: ip}); err != nil { |
Member
There was a problem hiding this comment.
Do we have a field indexer setup for this field?
Member
Author
There was a problem hiding this comment.
Yeah, the indexerField has been added already for this field, as part of other PR. This was the leftover change here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes #