chore(ci/deploy): run on maintainers PR #373
Draft
+88
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidvishnoi
reviewed
Oct 1, 2025
Member
There was a problem hiding this comment.
We can use TypeScript files directly
interledger/web-monetization-extension#1188
sidvishnoi
reviewed
Oct 1, 2025
Comment on lines
+34
to
+45
| # Build and test steps (always run for validation) | ||
| - name: Build API (validation) | ||
| if: steps.deploy-check.outputs.should-deploy == 'false' | ||
| run: pnpm -C api run build | ||
|
|
||
| - name: Build CDN (validation) | ||
| if: steps.deploy-check.outputs.should-deploy == 'false' | ||
| run: pnpm -C cdn run build | ||
|
|
||
| - name: Build Frontend (validation) | ||
| if: steps.deploy-check.outputs.should-deploy == 'false' | ||
| run: pnpm -C frontend run build |
Member
There was a problem hiding this comment.
Maybe instead of adding these, we can add a flag to ./.github/workflows/deploy-worker whether or not it should try to deploy.
sidvishnoi
reviewed
Oct 1, 2025
Comment on lines
+16
to
+20
| if (context.eventName === 'pull_request') { | ||
| const event = /** @type {PullRequest} */ (context.payload); | ||
| const authorAssociation = event.pull_request.author_association; | ||
|
|
||
| if (!isAllowedAuthor(authorAssociation)) { |
Member
There was a problem hiding this comment.
Can we trigger deployments on manual pull_request_review comments from maintainers like we do for extension? Maybe as a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.