Apps/shared configs/0xc loader #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the vite-node plugin loader from using esbuild to OxC (via transformWithOxc) for transforming TypeScript files, aligning with the project's broader adoption of OxC tooling. It also includes minor updates to the nutritionfacts app.
- Replaces
transformWithEsbuildwithtransformWithOxcin the vite-node loader plugin - Updates the loader module to use a default export instead of named exports
- Updates nutritionfacts app references from
Main.tsxtomain.tsx(case normalization)
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/vite-node.plugin.loader.mjs | Switches from esbuild to OxC transformer, reorganizes imports, and changes from named exports to default export |
| apps/nutritionfacts/src/app.tsx | Adds explicit parentheses around nested ternary operators (formatting improvement) |
| apps/nutritionfacts/package.json | Bumps version from 2.0.10 to 2.0.11 |
| apps/nutritionfacts/index.test.ts | Updates test expectation to match lowercase main.tsx filename |
| apps/nutritionfacts/index.html | Updates script source from Main.tsx to main.tsx |
| apps/nutritionfacts/coverage/coverage.yml | Reflects file renaming in coverage data (PascalCase to lowercase) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.