Skip to content

Conversation

@minghanm
Copy link

@minghanm minghanm commented Dec 7, 2024

Description

This PR updates the front-end file upload texts to include support for the HTML file format in addition to the existing formats (pdf, csv, txt, docx, xlsx).

Relevant context:
The change was made in the DragDrop component (src/components/DragDrop.js).
This addresses the feature request described in [issue #37 (https://github.com/harmonydata/harmony/issues/37).
The backend change for this feature is here: https://github.com/harmonydata/harmony/pull/72

Fixes #37

Type of change

  • New feature (non-breaking change which adds functionality)

Testing

To verify the changes, the following tests were performed:

Verified the updated text is rendered correctly in the DragDrop component.

Test Configuration

  • Library version: 1.0.1
  • OS: macOS Sonoma 14.0 (Darwin Kernel 24.0.0, ARM64)
  • Toolchain: npm v10.8.2, Node.js v18.20.5

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@netlify
Copy link

netlify bot commented Dec 7, 2024

👷 Deploy request for harmony-staging pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f2eb0b0

@minghanm minghanm marked this pull request as draft December 7, 2024 19:07
@minghanm minghanm marked this pull request as ready for review December 7, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant