Remove most disablings of clang-format #8874
Conversation
| #endif | ||
| #ifndef WEBGPU_H_ | ||
| #define WEBGPU_H_ | ||
|
|
There was a problem hiding this comment.
Did we put the clang-format comments in the *_mini.h files? Or were they there when we vendored them? Actually... did we vendor all of them?
There was a problem hiding this comment.
We didn't vendor all of them. For some of them with large APIs we just extern declared the things we use. Looks like for mini_webgpu.h Steven added a clang-format off with a note about some configurations really wanting to reformat that file despite it being in clang-format-ignore. Hopefully that's not an issue anymore.
alexreinking
left a comment
alexreinking
left a comment
There was a problem hiding this comment.
Really nice! I especially like the formatting improvements in the simplifier.
src/HexagonOffload.cpp
Outdated
|
|
||
| static const uint8_t hexagon_plt1[] = { | ||
| // clang-format off | ||
|
|
There was a problem hiding this comment.
CI's version of clang-format still really wants these.
Most of the cases where we disable clang-format were unnecessary or could be addressed in other ways (e.g. a trailing comment after EVAL_IN_LAMBDA). Happy to revert any of these changes if people think it's worth disabling clang-format in these cases. I left in uses of
clang-format offwhen it was necessary to preserve include order, or to keep things that read best as one-liners on one line.No functional changes intended.