Prevent error from being fused with scalar in simd_op_check #8867
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the output mismatch in fmls with float16 type where error() was optimized in a way that it is fused with scalar computation. compute_root() makes sure scalar result is computed independently.
Contributor
Author
|
In simd_op_check_wasm, i8x16.splat generates , which was previously for data reuse . |
zvookin
reviewed
Nov 18, 2025
| // Include a scalar version | ||
| Halide::Func f_scalar("scalar_" + name); | ||
| f_scalar(x, y) = e; | ||
| f_scalar.compute_root(); |
Member
There was a problem hiding this comment.
Might be worth a comment as to why this is necessary for correctness.
zvookin
approved these changes
Nov 18, 2025
Member
That's coming from these tests: // Load vector with identical lanes generates *.splat.
check("i8x16.splat", 16 * w, in_u8(0));
check("i16x8.splat", 8 * w, in_u16(0));
check("i32x4.splat", 4 * w, in_u32(0));
check("i64x2.splat", 2 * w, in_u64(0));I think it's actually an improvement to use |
alexreinking
approved these changes
Nov 18, 2025
Member
alexreinking
left a comment
alexreinking
left a comment
There was a problem hiding this comment.
I just fixed simd_op_check_wasm myself. Hope this works!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the output mismatch in fmls with float16 type where error() was optimized in a way that it is fused with scalar computation. compute_root() makes sure scalar result is computed independently.