Upgrades to tools and linting #1276
Draft
+1,612
−1,656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update catalog versions: - eslint: 9.37.0 -> 9.39.2 - @typescript-eslint/*: 8.46.1 -> 8.53.0 - prettier: 3.6.2 -> 3.7.4 - mocha: 11.7.1 -> 11.7.5 - markdownlint-cli: 0.45.0 -> 0.47.0 - lint-staged: 16.2.4 -> 16.2.7 - ethers: 6.15.0 -> 6.16.0 - viem: pinned to 2.31.7 (2.37.6+ breaks WAGMI generation) Note: solhint kept at 6.0.1 (6.0.2 has debug logging bug)
…ment Replace overly-broad `**/*` glob patterns with targeted paths like `packages/**/*` to avoid scanning root node_modules directory. Add explicit prettierignore path for token-distribution package to prevent linting auto-generated .graphclient-extracted files. - Lint warm cache: 28s → 18s (36% faster) - Clean sequential output with no parallel execution - Protects .graphclient-extracted from formatting changes Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Disable markdownlint rule MD040 to permit fenced code blocks without language identifiers. This is useful for generic code examples or when the language is contextually obvious. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Runs `pnpm lint:forge` in CI for Solidity files in horizon and subgraph-service packages. Only triggers when relevant files change.
Upgrades to tools and linting
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1276 +/- ##
==========================================
+ Coverage 84.06% 86.74% +2.67%
==========================================
Files 42 46 +4
Lines 2071 2451 +380
Branches 615 730 +115
==========================================
+ Hits 1741 2126 +385
+ Misses 330 325 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The glob pattern `*/.graphclient-extracted/*` only matched paths with one directory before .graphclient-extracted. Changed to substring matching so paths like `packages/token-distribution/.graphclient-extracted/` are correctly ignored.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request upgrades various development tools and introduces forge linting to the project. The changes include dependency version updates, new linting scripts, test constant naming standardization, and code adjustments to satisfy linting requirements.
Changes:
- Updated development dependencies (ESLint, TypeScript ESLint, linting tools, Prettier, etc.)
- Added forge linting infrastructure with configuration and CI integration
- Standardized test constants to SCREAMING_SNAKE_CASE naming convention
- Changed imports from bare style to named imports for better linting compliance
- Added forge-lint disable comments for legitimate linting exceptions
Reviewed changes
Copilot reviewed 137 out of 139 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updated versions for development tools (eslint, typescript-eslint, prettier, etc.); pinned viem version |
| package.json (root) | Updated pnpm version, added forge linting to scripts, refined glob patterns for linting |
| packages/*/package.json | Added forge linting script to horizon and subgraph-service packages |
| scripts/lint-staged-run.sh | Improved ignore pattern matching from glob to substring matching |
| .github/workflows/lint.yml | Added forge linting step to CI workflow |
| foundry.toml | Added lint configuration to ignore hardhat-specific imports |
| .markdownlint.json | Added MD040 rule exception |
| .gitignore | Added 'core' to ignored files |
| Test files (*.t.sol) | Renamed constants from camelCase to SCREAMING_SNAKE_CASE; changed imports to named style |
| Contract files (*.sol) | Added forge-lint disable comments for known exceptions |
| TypeScript files | Minor formatting adjustments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.