Skip to content

Conversation

@greggman
Copy link
Contributor

@greggman greggman commented Jan 13, 2026

These functions took a device. Switched to features lets them take a device, or an adapter, or a set of features.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@greggman greggman requested a review from kainino0x January 13, 2026 04:06
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

Results for build job (at 4ea86b5):

 Test case/subcase counts did not change.

These functions took a device. Switched to features lets
them take a device, or an adapter, or a subset of features.
@greggman greggman force-pushed the refactor-format-info-2-features branch from 137315f to 4ea86b5 Compare January 14, 2026 02:24
@greggman greggman enabled auto-merge (squash) January 14, 2026 02:24
@greggman greggman merged commit db3a77f into gpuweb:main Jan 14, 2026
1 check passed
@greggman greggman deleted the refactor-format-info-2-features branch January 14, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants