fix: flaky tests due to imprecision in floating point calculation and performance test setup #865
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid floating point conversion imprecision
Fix linter error with black
Ensure URL encoding takes enough time so that cached version is measurably 10x faster
mrfaizal
changed the title
coryan
previously approved these changes
Nov 14, 2025
vchudnov-g
requested changes
Nov 14, 2025
Change code to skip flaky test and add a new test that uses a constant timeout instead of a number to check that override works
product-auto-label
bot
added
size: s
vchudnov-g
approved these changes
Nov 17, 2025
Contributor
vchudnov-g
left a comment
vchudnov-g
left a comment
There was a problem hiding this comment.
Please do update the PR description to be more informative
This was referenced Jan 8, 2026
daniel-sanche
added a commit
that referenced
this pull request
Jan 8, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v1.0.1 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620 <details><summary>google-api-core: 2.29.0</summary> ## [2.29.0](v2.28.1...v2.29.0) (2026-01-08) ### Features * make parse_version_to_tuple public (#864) ([c969186](c969186f)) * Auto enable mTLS when supported certificates are detected (#869) ([f8bf6f9](f8bf6f96)) ### Bug Fixes * remove call to importlib.metadata.packages_distributions() for py38/py39 (#859) ([628003e](628003e2)) * Log version check errors (#858) ([6493118](6493118c)) * flaky tests due to imprecision in floating point calculation and performance test setup (#865) ([9340408](93404080)) * closes tailing streams in bidi classes. (#851) ([c97b3a0](c97b3a00)) </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flaky tests due to imprecision in floating point calculation and performance test setup