Skip to content

Conversation

@sagnghos
Copy link
Contributor

@sagnghos sagnghos commented Jan 7, 2026

Skipping the PGErrorCode assert check in ITQueryTest.badquery till b/473270453 is fixed

@sagnghos sagnghos requested review from a team as code owners January 7, 2026 08:19
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Jan 7, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @sagnghos, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request temporarily adjusts a test case in ITQueryTest.java to prevent failures when executed against an experimental host environment. It specifically modifies the badQuery test to skip an assertion for a PostgreSQL error code, acknowledging an ongoing issue that needs to be resolved separately. This ensures the test suite remains stable while development continues on the experimental host.

Highlights

  • Test Logic Modification: The ITQueryTest.badquery test now conditionally skips the PGErrorCode assertion (42703) when running against an experimental host.
  • Experimental Host Support: A check for isExperimentalHost() has been introduced to adapt test behavior for environments under development, specifically to address a known issue (b/473270453).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@sagnghos sagnghos force-pushed the sagnghos/expHostSkipPGCodeCheck branch from 3481a22 to 02f4192 Compare January 7, 2026 08:20
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request temporarily disables a failing assertion in ITQueryTest.badquery when running against an experimental host, to work around a known issue. The change is correct and addresses the problem. I've provided one suggestion to use assumeFalse instead of an if block. This is a more idiomatic way to handle conditional test execution in JUnit and improves test reporting by marking the test as skipped rather than passing silently.

@olavloite olavloite added the automerge Merge the pull request once unit tests and other checks pass. label Jan 7, 2026
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 8, 2026
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2026
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants