Skip to content

Conversation

@fredbi
Copy link
Member

@fredbi fredbi commented Dec 24, 2025

Change type

Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update

Short description

Fixes

Full description

Checklist

  • I have signed all my commits with my name and email (see DCO. This does not require a PGP-signed commit
  • I have rebased and squashed my work, so only one commit remains
  • I have added tests to cover my changes.
  • I have properly enriched go doc comments in code.
  • I have properly documented any breaking change.

* fixes go-openapi#216

Signed-off-by: Frédéric BIDON <fredbi@yahoo.com>
@fredbi fredbi force-pushed the fix/216-unmarshal-quoted branch from 0672d07 to 0a376bf Compare December 24, 2025 15:56
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.22%. Comparing base (e64b092) to head (0a376bf).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
properties.go 52.38% 5 Missing and 5 partials ⚠️

❌ Your patch status has failed because the patch coverage (52.38%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage   67.45%   67.22%   -0.24%     
==========================================
  Files          30       30              
  Lines        2397     2407      +10     
==========================================
+ Hits         1617     1618       +1     
- Misses        616      621       +5     
- Partials      164      168       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredbi fredbi merged commit 3b2ff60 into go-openapi:master Dec 24, 2025
20 of 21 checks passed
@fredbi fredbi deleted the fix/216-unmarshal-quoted branch December 24, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OrderSchemaItems.MarshalJSON generates invalid JSON when keys contain special characters (e.g. newline)

1 participant