Add missing dependency #18966
Merged
Add missing dependency #18966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query pack has suites that rely on the `codeql/suite-helpers` pack, but doesn't include it as a dependency. This will cause error when resolving suites referring the Actions query pack.
Contributor
There was a problem hiding this comment.
PR Overview
This PR adds a missing dependency to the query pack to ensure that suites relying on the codeql/suite-helpers pack resolve correctly.
- Added dependency for codeql/suite-helpers in qlpack.yml.
Reviewed Changes
| File | Description |
|---|---|
| actions/ql/src/qlpack.yml | Added missing dependency for suite helpers |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
adityasharad
approved these changes
Mar 11, 2025
Collaborator
adityasharad
left a comment
adityasharad
left a comment
There was a problem hiding this comment.
Do we need this in 2.20.7 as well?
Contributor
Author
|
It currently means the actions/queries pack is broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query pack has suites that rely on the
codeql/suite-helperspack, but doesn't include it as a dependency. This will cause error when resolving suites referring the Actions query pack.