Skip to content

fix(environments): Handle missing default environment in event processing #106937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seer-by-sentry wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(environments): Handle missing default environment in event processing #106937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/sentry/services/eventstore/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,10 +178,20 @@ def get_environment(self) -> Environment:
from sentry.models.environment import Environment

if not hasattr(self, "_environment_cache"):
self._environment_cache = Environment.get_for_organization_id(
organization_id=self.project.organization_id,
name=Environment.get_name_or_default(self.get_tag("environment")),
)
name = Environment.get_name_or_default(self.get_tag("environment"))
organization_id = self.project.organization_id
try:
self._environment_cache = Environment.get_for_organization_id(
organization_id=organization_id,
name=name,
)
except Environment.DoesNotExist:
# The Environment may not exist if this is the first event without an
# environment tag for this organization. Create it to avoid errors in
# post-processing steps that depend on get_environment().
self._environment_cache = Environment.objects.get_or_create(
name=name, organization_id=organization_id
)[0]

return self._environment_cache

Expand Down
Loading