ref(tests): Remove is_eap parameter, use only EAP codepath #106936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the is_eap parameter from store_span, store_spans, store_segment, store_indexed_span, and create_event test utilities. The non-EAP codepath is no longer needed as all span storage now uses the EAP endpoint. This simplifies the test utilities by removing the conditional logic and always using span_to_trace_item() to convert spans before posting to the EAP_ITEMS_INSERT_ENDPOINT. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Backend
Contributor
Author
|
This will be needed before we push this https://github.com/getsentry/getsentry/pull/19203. |
JoshFerge
approved these changes
Jan 26, 2026
wmak
approved these changes
Jan 26, 2026
shashjar
approved these changes
Jan 26, 2026
priscilawebdev
pushed a commit
that referenced
this pull request
Jan 28, 2026
## Summary - Remove the `is_eap` parameter from `store_span`, `store_spans`, `store_segment`, `store_indexed_span`, and `create_event` test utilities - The non-EAP codepath is no longer needed as all span storage now uses the EAP endpoint - This simplifies the test utilities by removing the conditional logic and always using `span_to_trace_item()` to convert spans before posting to the `EAP_ITEMS_INSERT_ENDPOINT` ## Test plan - All existing tests should pass since they were already using `is_eap=True` Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
is_eapparameter fromstore_span,store_spans,store_segment,store_indexed_span, andcreate_eventtest utilitiesspan_to_trace_item()to convert spans before posting to theEAP_ITEMS_INSERT_ENDPOINTTest plan
is_eap=True