fix(cursor): Handle empty branch_name when launching Cursor agent #106933
+101
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
branch_nameis an empty string, the Cursor API returns an error:This fix converts empty/falsy
branch_nametoNone, which gets excluded from the JSON payload viaexclude_none=True, allowing Cursor to automatically resolve to the repository's default branch.Root Cause Analysis
The issue occurs when:
branch_nameleft blank, expecting default branch to be used)update_repo_access_and_properties()cannot resolve the default branch because the repo is not readablebranch_namestays empty"ref": ""and rejects itNote: When the Sentry GitHub app HAS read access, Seer correctly resolves
branch_nameto the default branch during autofix run creation.Why This Fix Helps
This is a workaround for cases where:
ref: "")The proper fix is ensuring users install the Sentry GitHub app on their repos. A companion PR adds logging in Seer to help identify when this happens: https://github.com/getsentry/seer/pull/4619
Verified with Cursor API
Test plan