feat(aci): Add ability to filter group open periods by event_id #106930
+62
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
malwilley
commented
Jan 26, 2026
| .order_by("-date_started") | ||
| ) | ||
|
|
||
| return group_open_periods[:limit] |
Member
Author
There was a problem hiding this comment.
This will be handled by self.paginate(). This function isn't used anywhere else
ceorourke
approved these changes
Jan 26, 2026
malwilley
deleted the
malwilley/feat/add-ability-to-filter-group-open-periods-by-event-id
branch
dashed
pushed a commit
that referenced
this pull request
Jan 26, 2026
dashed
pushed a commit
that referenced
this pull request
Jan 26, 2026
JonasBa
pushed a commit
that referenced
this pull request
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ISWF-905