feat(uptime): Display assertion compilation errors in form #106922
Merged
+269
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
scttcper
reviewed
Jan 24, 2026
| /** | ||
| * Checks if an object is an assertion error with error type and details. | ||
| */ | ||
| function isAssertionError(obj: any): obj is {details: string; error: string} { |
Member
There was a problem hiding this comment.
should this be unknown
Suggested change
| function isAssertionError(obj: any): obj is {details: string; error: string} { | |
| function isAssertionError(obj: unknown): obj is {details: string; error: string} { |
scttcper
approved these changes
Jan 24, 2026
Add error handling for assertion compilation/serialization errors from
the uptime-checker validator. When the API returns an error like
`{"assertion": {"error": "compilation_error", "details": "..."}}`,
the form now properly extracts and displays the error message on
the Assertions field in the Verification section.
Add descriptive titles to assertion validation errors based on error type: - "Compilation Error" for invalid JSON path syntax - "Serialization Error" for malformed assertion structure - "Validation Error" as fallback Also adds test coverage for serialization errors.
jaydgoss
force-pushed
the
jaygoss/new-700-display-complication-errors-for-uptime-assertion-fields
branch
from
1c61b59 to
5fba1f3
Compare
- Extract assertion error mapping to shared utility (assertionFormErrors.tsx)
- Handle both API response formats:
- Direct: {"assertion": {"error": "...", "details": "..."}}
- Nested: {"dataSources": {"assertion": {"error": "...", "details": "..."}}}
- Add mapAssertionFormErrors to detector create/edit forms
- Add comprehensive unit tests for error mapping
jaydgoss
force-pushed
the
jaygoss/new-700-display-complication-errors-for-uptime-assertion-fields
branch
from
5fba1f3 to
a11387c
Compare
jaydgoss
deleted the
jaygoss/new-700-display-complication-errors-for-uptime-assertion-fields
branch
dashed
pushed a commit
that referenced
this pull request
Jan 26, 2026
## Summary
Display assertion compilation/serialization errors from the
uptime-checker validator in uptime monitor forms. When an invalid
assertion is submitted (e.g., malformed JSON path syntax), the error is
now displayed on the Assertions field in the Verification section with a
descriptive title.
### Changes
- Add `mapAssertionFormErrors` utility to transform assertion errors
into form-friendly format
- Handle two API response formats:
- Direct: `{"assertion": {"error": "...", "details": "..."}}` (uptime
alerts)
- Nested: `{"dataSources": {"assertion": {"error": "...", "details":
"..."}}}` (detector forms)
- Add descriptive error titles based on error type:
- "Compilation Error" - invalid JSON path syntax
- "Serialization Error" - malformed assertion structure
- "Validation Error" - fallback for unknown error types
- Apply error handling to all uptime forms:
- Uptime Alert create/edit (`/alerts/rules/uptime/`)
- Uptime Detector create (`/detectors/uptime/new/`)
- Uptime Detector edit (`/detectors/uptime/:id/edit/`)
## Manual Test Plan
1. **Test compilation error in Uptime Alert form:**
- Go to Alerts → Create Alert → Uptime
- Fill in required fields (project, environment, URL, name)
- Add a JSON Path assertion with invalid syntax (e.g., `$[invalid`)
- Click "Create Rule"
- Verify error appears on Assertions field: "Compilation Error: ..."
2. **Test compilation error in Detector form:**
- Go to Monitors → New Monitor → Uptime
- Fill in required fields
- Add a JSON Path assertion with invalid syntax
- Click "Create"
- Verify error appears on Assertions field: "Compilation Error: ..."
3. **Test serialization error:**
- This requires sending a malformed assertion structure (e.g., invalid
op type)
- Can be tested via unit tests or by temporarily modifying the form's
onPreSubmit
Fixes NEW-700
JonasBa
pushed a commit
that referenced
this pull request
Jan 27, 2026
## Summary
Display assertion compilation/serialization errors from the
uptime-checker validator in uptime monitor forms. When an invalid
assertion is submitted (e.g., malformed JSON path syntax), the error is
now displayed on the Assertions field in the Verification section with a
descriptive title.
### Changes
- Add `mapAssertionFormErrors` utility to transform assertion errors
into form-friendly format
- Handle two API response formats:
- Direct: `{"assertion": {"error": "...", "details": "..."}}` (uptime
alerts)
- Nested: `{"dataSources": {"assertion": {"error": "...", "details":
"..."}}}` (detector forms)
- Add descriptive error titles based on error type:
- "Compilation Error" - invalid JSON path syntax
- "Serialization Error" - malformed assertion structure
- "Validation Error" - fallback for unknown error types
- Apply error handling to all uptime forms:
- Uptime Alert create/edit (`/alerts/rules/uptime/`)
- Uptime Detector create (`/detectors/uptime/new/`)
- Uptime Detector edit (`/detectors/uptime/:id/edit/`)
## Manual Test Plan
1. **Test compilation error in Uptime Alert form:**
- Go to Alerts → Create Alert → Uptime
- Fill in required fields (project, environment, URL, name)
- Add a JSON Path assertion with invalid syntax (e.g., `$[invalid`)
- Click "Create Rule"
- Verify error appears on Assertions field: "Compilation Error: ..."
2. **Test compilation error in Detector form:**
- Go to Monitors → New Monitor → Uptime
- Fill in required fields
- Add a JSON Path assertion with invalid syntax
- Click "Create"
- Verify error appears on Assertions field: "Compilation Error: ..."
3. **Test serialization error:**
- This requires sending a malformed assertion structure (e.g., invalid
op type)
- Can be tested via unit tests or by temporarily modifying the form's
onPreSubmit
Fixes NEW-700
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Display assertion compilation/serialization errors from the uptime-checker validator in uptime monitor forms. When an invalid assertion is submitted (e.g., malformed JSON path syntax), the error is now displayed on the Assertions field in the Verification section with a descriptive title.
Changes
mapAssertionFormErrorsutility to transform assertion errors into form-friendly format{"assertion": {"error": "...", "details": "..."}}(uptime alerts){"dataSources": {"assertion": {"error": "...", "details": "..."}}}(detector forms)/alerts/rules/uptime/)/detectors/uptime/new/)/detectors/uptime/:id/edit/)Manual Test Plan
Test compilation error in Uptime Alert form:
$[invalid)Test compilation error in Detector form:
Test serialization error:
Fixes NEW-700