Skip to content

fix(feedback): Fix cases where the outline of inputs were wrong #18647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryan953 wants to merge 1 commit into
base: develop
Choose a base branch
from
+3 −2
Open

fix(feedback): Fix cases where the outline of inputs were wrong #18647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/feedback/src/core/createMainStyles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export function createMainStyles({
font-family: var(--font-family);
font-size: var(--font-size);

${colorScheme !== 'system' ? 'color-scheme: only light;' : ''}
${colorScheme !== 'system' ? `color-scheme: only ${colorScheme};` : ''}

${getThemedCssVariables(
colorScheme === 'dark' ? { ...DEFAULT_DARK, ...themeDark } : { ...DEFAULT_LIGHT, ...themeLight },
Expand All @@ -83,12 +83,13 @@ ${
? `
@media (prefers-color-scheme: dark) {
:host {
color-scheme: only dark;

${getThemedCssVariables({ ...DEFAULT_DARK, ...themeDark })}
}
}`
: ''
}
}
Copy link
Member Author

@ryan953 ryan953 Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an extra closing brace doing nothing good nor bad.

I spotted it in the output though, we don't need it.

Image Image

Copy link

@cursor cursor bot Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix PR missing automated regression test (Bugbot Rules)

Per the review rules: when reviewing a fix PR, check if it includes at least one unit, integration, or e2e test that tests the regression being fixed. This fix for color-scheme behavior doesn't appear to include any automated test. While CSS visual testing can be challenging and the PR includes manual testing with before/after screenshots, adding an automated test that verifies the generated CSS output for different colorScheme values ('light', 'dark', 'system') would help prevent future regressions.

Fix in Cursor Fix in Web

`;

if (styleNonce) {
Expand Down
Loading