-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(nuxt): Inject debug IDs only once at build end #18561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
s1gr1d
wants to merge
1
commit into
develop
Choose a base branch
from
sig/nuxt-sourcemap-end
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+151
−3
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| import { existsSync } from 'node:fs'; | ||
| import type { Nuxt } from '@nuxt/schema'; | ||
| import type { createSentryBuildPluginManager as createSentryBuildPluginManagerType } from '@sentry/bundler-plugin-core'; | ||
| import * as path from 'path'; | ||
| import type { SentryNuxtModuleOptions } from '../common/types'; | ||
| import { getPluginOptions } from './sourceMaps'; | ||
|
|
||
| /** | ||
| * A build-end hook that handles Sentry release creation and source map uploads. | ||
| * It creates a new Sentry release if configured, uploads source maps to Sentry, | ||
| * and optionally deletes the source map files after upload. | ||
| * | ||
| * This runs after both Vite (Nuxt) and Rollup (Nitro) builds complete, ensuring | ||
| * debug IDs are injected and source maps uploaded only once. | ||
| */ | ||
| // eslint-disable-next-line complexity | ||
| export async function handleBuildDoneHook(sentryModuleOptions: SentryNuxtModuleOptions, nuxt: Nuxt): Promise<void> { | ||
| const debug = sentryModuleOptions.debug ?? false; | ||
| if (debug) { | ||
| // eslint-disable-next-line no-console | ||
| console.log('[Sentry] Running build:done hook to upload source maps.'); | ||
| } | ||
|
|
||
| // eslint-disable-next-line deprecation/deprecation | ||
| const sourceMapsUploadOptions = sentryModuleOptions.sourceMapsUploadOptions || {}; | ||
|
|
||
| const sourceMapsEnabled = | ||
| sentryModuleOptions.sourcemaps?.disable === true | ||
| ? false | ||
| : sentryModuleOptions.sourcemaps?.disable === false | ||
| ? true | ||
| : // eslint-disable-next-line deprecation/deprecation | ||
| (sourceMapsUploadOptions.enabled ?? true); | ||
|
|
||
| if (!sourceMapsEnabled) { | ||
| return; | ||
| } | ||
|
|
||
| let createSentryBuildPluginManager: typeof createSentryBuildPluginManagerType | undefined; | ||
| try { | ||
| const bundlerPluginCore = await import('@sentry/bundler-plugin-core'); | ||
| createSentryBuildPluginManager = bundlerPluginCore.createSentryBuildPluginManager; | ||
| } catch (error) { | ||
| // eslint-disable-next-line no-console | ||
| debug && console.warn('[Sentry] Could not load build manager package. Will not upload source maps.', error); | ||
| return; | ||
| } | ||
|
|
||
| if (!createSentryBuildPluginManager) { | ||
| // eslint-disable-next-line no-console | ||
| debug && console.warn('[Sentry] Could not find createSentryBuildPluginManager in bundler plugin core.'); | ||
| return; | ||
| } | ||
|
|
||
| const outputDir = nuxt.options.nitro?.output?.dir || path.join(nuxt.options.rootDir, '.output'); | ||
|
|
||
| if (!existsSync(outputDir)) { | ||
| // eslint-disable-next-line no-console | ||
| debug && console.warn(`[Sentry] Output directory does not exist yet: ${outputDir}. Skipping source map upload.`); | ||
| return; | ||
| } | ||
|
|
||
| const options = getPluginOptions(sentryModuleOptions, undefined); | ||
|
|
||
| const existingIgnore = options.sourcemaps?.ignore || []; | ||
| const ignorePatterns = Array.isArray(existingIgnore) ? existingIgnore : [existingIgnore]; | ||
|
|
||
| // node_modules source maps are ignored | ||
| const nodeModulesPatterns = ['**/node_modules/**', '**/node_modules/**/*.map']; | ||
| const hasNodeModulesIgnore = ignorePatterns.some( | ||
| pattern => typeof pattern === 'string' && pattern.includes('node_modules'), | ||
| ); | ||
|
|
||
| if (!hasNodeModulesIgnore) { | ||
| ignorePatterns.push(...nodeModulesPatterns); | ||
| } | ||
|
|
||
| options.sourcemaps = { | ||
| ...options.sourcemaps, | ||
| ignore: ignorePatterns.length > 0 ? ignorePatterns : undefined, | ||
| }; | ||
|
|
||
| if (debug && ignorePatterns.length > 0) { | ||
| // eslint-disable-next-line no-console | ||
| console.log(`[Sentry] Excluding patterns from source map upload: ${ignorePatterns.join(', ')}`); | ||
| } | ||
|
|
||
| try { | ||
| const sentryBuildPluginManager = createSentryBuildPluginManager(options, { | ||
| buildTool: 'nuxt', | ||
| loggerPrefix: '[Sentry Nuxt Module]', | ||
| }); | ||
|
|
||
| await sentryBuildPluginManager.telemetry.emitBundlerPluginExecutionSignal(); | ||
| await sentryBuildPluginManager.createRelease(); | ||
| await sentryBuildPluginManager.injectDebugIds([outputDir]); | ||
| await sentryBuildPluginManager.uploadSourcemaps([outputDir], { | ||
| prepareArtifacts: false, | ||
| }); | ||
|
|
||
| await sentryBuildPluginManager.deleteArtifacts(); | ||
|
|
||
| // eslint-disable-next-line no-console | ||
| debug && console.log('[Sentry] Successfully uploaded source maps.'); | ||
| } catch (error) { | ||
| // eslint-disable-next-line no-console | ||
| console.error('[Sentry] Error during source map upload:', error); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may still want to create a release?