-
-
Notifications
You must be signed in to change notification settings - Fork 236
feat: Support missing calls with multi-project the options #3001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JPeer264, apologies I did not notice this earlier, but I just realized that the server actually completely ignores the projects supplied to the releases set-commits and releases finalize commands. Setting commits and finalizing releases seem to affect the release directly, and there is no way to scope such updates to a specific project. So, we should not add the ability to set projects for these to the JS API. I will modify the Rust code to ignore the --project for these commands — however, as the --project argument is a global flag, we will not fully remove the argument in the CLI side.
However, for deploys new, the server does respect the projects passed. If no projects are specified, we create the deploy for all projects on the release; otherwise, the deploy is only created for the specified projects.
| */ | ||
| url?: string; | ||
| /** | ||
| * The projects to deploy the release to. If not provided, the deployment will be created for the default project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * The projects to deploy the release to. If not provided, the deployment will be created for the default project. | |
| * The projects to deploy the release to. If not provided, the deployment will be created for all projects associated with the release. |
|
Also, does this change allow |
a69c17c to
fdc3cae
Compare
bc0a8dc to
8d3aa8b
Compare
7a09a4e to
aa1e54c
Compare
80dd453 to
8ebd398
Compare
8ebd398 to
0060a64
Compare
This adds more support for having multiple projects where the Rust API had already support. This only affects
.newDeploy()Closes #2902
Closes CLI-212