Skip to content

Conversation

@JPeer264
Copy link
Member

@JPeer264 JPeer264 commented Dec 2, 2025

This adds more support for having multiple projects where the Rust API had already support. This only affects .newDeploy()

Closes #2902
Closes CLI-212

@JPeer264 JPeer264 self-assigned this Dec 2, 2025
@JPeer264 JPeer264 requested review from a team as code owners December 2, 2025 13:10
@JPeer264 JPeer264 added the v3.0 Breaking changes to include in version 3.0.0 of Sentry CLI label Dec 2, 2025
@JPeer264 JPeer264 requested review from stephanie-anderson and removed request for a team December 2, 2025 13:10
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 0060a64

@linear
Copy link

linear bot commented Dec 2, 2025

@szokeasaurusrex szokeasaurusrex removed the request for review from stephanie-anderson December 2, 2025 13:21
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JPeer264, apologies I did not notice this earlier, but I just realized that the server actually completely ignores the projects supplied to the releases set-commits and releases finalize commands. Setting commits and finalizing releases seem to affect the release directly, and there is no way to scope such updates to a specific project. So, we should not add the ability to set projects for these to the JS API. I will modify the Rust code to ignore the --project for these commands — however, as the --project argument is a global flag, we will not fully remove the argument in the CLI side.

However, for deploys new, the server does respect the projects passed. If no projects are specified, we create the deploy for all projects on the release; otherwise, the deploy is only created for the specified projects.

*/
url?: string;
/**
* The projects to deploy the release to. If not provided, the deployment will be created for the default project.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The projects to deploy the release to. If not provided, the deployment will be created for the default project.
* The projects to deploy the release to. If not provided, the deployment will be created for all projects associated with the release.

@szokeasaurusrex
Copy link
Member

Also, does this change allow releases new to accept multiple projects?

@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner December 10, 2025 14:11
@szokeasaurusrex szokeasaurusrex force-pushed the jp/upgrade-node-fetch branch 2 times, most recently from bc0a8dc to 8d3aa8b Compare December 11, 2025 09:59
@JPeer264 JPeer264 removed the v3.0 Breaking changes to include in version 3.0.0 of Sentry CLI label Dec 11, 2025
@szokeasaurusrex szokeasaurusrex force-pushed the jp/upgrade-node-fetch branch 6 times, most recently from 7a09a4e to aa1e54c Compare December 15, 2025 10:41
Base automatically changed from jp/upgrade-node-fetch to master December 15, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align JS API between commands that accept multiple projects

3 participants