-
-
Notifications
You must be signed in to change notification settings - Fork 176
[WIP] fail when repository cannot init #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@epifanio see the 3 commits in this PR which represent different approaches that you can test in your deployment when you have a chance: |
|
Only 0bd11f5 makes sense in the while loop context. The other commits would be better if they removed the while loop. |
|
This Pull Request has been inactive for 90 days. In order to manage maintenance burden, it will be automatically closed in 7 days. |
|
Still valid/in scope. |
|
This Pull Request has been inactive for 90 days. In order to manage maintenance burden, it will be automatically closed in 7 days. |
|
This Pull Request has been closed due to there being no activity for more than 90 days. |
|
still in scope |
Overview
This PR causes pycsw to fail on repository initialization if a connection cannot be made to the underlying metadata repository (current behaviour fails silently on repository init, and provides misleading error on subsequent interactions with
self.repository).Related Issue / Discussion
None
Additional Information
None
Contributions and Licensing
(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)