Update test statistics to support generic type 'T data #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvenn
reviewed
Aug 4, 2025
| ) | ||
| testCase "_ln(0!) = 0" (fun _ -> | ||
| Expect.equal (Factorial._factorialLn 0) 0. "Expected factorialLn of 0 to be 1." | ||
| Expect.floatClose Accuracy.high (Factorial._factorialLn 0) 0. "Expected factorialLn of 0 to be 1." |
Member
There was a problem hiding this comment.
Why is this change necessary? Is it just to align with other tests or is ln(0!) <> 0?
Member
|
@LibraChris is this still relevant for #352 ? Can you rebase this to target the |
LibraChris
force-pushed
the
updateTestStatistics
branch
from
5105948 to
f6be840
Compare
Marked _betaLn, _beta, betaLn, and beta functions as 'inline' to enable generic numeric support.
LibraChris
force-pushed
the
updateTestStatistics
branch
from
3048f31 to
77ba43e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial update for Tests to support generic type 'T data.
[Required] please make sure you checked that