-
Notifications
You must be signed in to change notification settings - Fork 47
Support (Secondary) Locations via collection references in Ashby Plugin #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
- Add new Locations data source that extracts unique locations from jobs - Add location reference and secondary locations fields to jobs - Support slugified location IDs for collection references - Allow data source selection in setup UI (Jobs vs Locations) - Add CLAUDE.md for repository documentation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add optional getItemId callback to AshbyDataSource interface - Locations data source defines getItemId using shared getLocationId function - Collection reference fields look up target data source's getItemId - Simplifies data.ts by removing special-case handling Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Use Unicode property escapes (\p{L}\p{N}) instead of \w
- Handles location names like "東京", "São Paulo", "München"
- Add vitest and tests for slugify function
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
c998ef6 to
43087ed
Compare
Replace manual 'in' operator check with valibot schema validation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
triozer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Testing