Skip to content

Conversation

@niekert
Copy link
Member

@niekert niekert commented Jan 21, 2026

Description

  • Add new Locations data source that extracts unique locations from jobs board
  • Add location reference and secondary locations fields to jobs data source
  • Allow data source selection in setup UI (Jobs vs Locations)
  • Add CLAUDE.md for repository documentation

Testing

  • Setup Locations Collection
    • Open Framer and create a new CMS collection
    • Launch the Ashby plugin
    • Enter your Job Board Name (see slack)
    • Select "Locations" from the Collection dropdown
    • Click "Next"
    • Map the desired fields:
    • Click "Sync" and verify locations are imported
    • Confirm unique locations are extracted from both primary and secondary job locations
  • Setup Jobs Collection with Location References
    • Create another new CMS collection
    • Launch the Ashby plugin again
    • Enter the same Job Board Name
    • Select "Jobs" from the Collection dropdown
    • Click "Next"
    • Map standard job fields as needed
    • Map location reference fields:
      • Location Reference → should show the Locations collection as target
      • Secondary Locations → should show the Locations collection as target (multi-reference)
    • Click "Sync"
  • Verify Data Integrity
    • Open a synced Job item
    • Confirm "Location Reference" links to the correct Location item
    • Confirm "Secondary Locations" contains all additional locations for that job
    • Cross-reference with the Ashby job board to verify accuracy
    • Check that location slugs match between Jobs references and Locations collection IDs

@niekert niekert marked this pull request as draft January 21, 2026 11:46
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

niekert and others added 3 commits January 21, 2026 13:34
- Add new Locations data source that extracts unique locations from jobs
- Add location reference and secondary locations fields to jobs
- Support slugified location IDs for collection references
- Allow data source selection in setup UI (Jobs vs Locations)
- Add CLAUDE.md for repository documentation

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add optional getItemId callback to AshbyDataSource interface
- Locations data source defines getItemId using shared getLocationId function
- Collection reference fields look up target data source's getItemId
- Simplifies data.ts by removing special-case handling

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Use Unicode property escapes (\p{L}\p{N}) instead of \w
- Handles location names like "東京", "São Paulo", "München"
- Add vitest and tests for slugify function

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@niekert niekert force-pushed the feat/secondary-locations-ashby branch from c998ef6 to 43087ed Compare January 21, 2026 12:35
niekert and others added 3 commits January 21, 2026 13:35
Replace manual 'in' operator check with valibot schema validation.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@niekert niekert marked this pull request as ready for review January 21, 2026 12:52
@niekert niekert changed the title Support Secondary Location references in Ashby Plugin Support (Secondary) Locations via collection references in Ashby Plugin Jan 21, 2026
@niekert niekert requested a review from triozer January 21, 2026 12:53
Copy link
Member

@triozer triozer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@niekert niekert added this pull request to the merge queue Jan 21, 2026
Merged via the queue into main with commit 44e4c5a Jan 21, 2026
6 checks passed
@niekert niekert deleted the feat/secondary-locations-ashby branch January 21, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants