-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
refactor(device_info_plus)!: remove serialNumber property
#3663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(device_info_plus)!: remove serialNumber property
#3663
Conversation
|
I would be in favor of removing the property, so doing a deprecation that returns unknown sounds good to me. Reading the docs on the I am kind of surprised that in #3655 the author managed to make it work on version 10 of the plugin, I don't think there should be any difference? Anyway, I am in favor of removing the property. @vbuberen what do you think? |
|
I am with you here about deletion. |
|
Agreed, let's remove it. @StanleyCocos if you can, update the PR and remove the parameter completely instead, and mark the PR as breaking change so we don't forget. |
serialNumber as deprecated and always return "unknown"|
Thank you all. Considering the next version is a breaking change, directly removing it is a good idea for me. I have already removed it and marked it as a breaking change. |
serialNumber property
vbuberen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well.
Description
fix: #3655
This method is essentially unavailable for most developers and can only be used in a very small number of special cases. However, some manufacturers have now tightened restrictions—even performing static scans and blocking app submission if your code references it. Therefore, I believe this method should be removed to lift these restrictions. For the rare special cases, using the old version or a fork is a more reasonable approach.
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).