Skip to content

Conversation

@eschabell
Copy link
Collaborator

@eschabell eschabell commented Jan 26, 2026

  • Change boolean defaults from 'off' to 'false' to match source code: lowercase, read_from_tail, strip_underscores
  • Fix grammar in db.sync description: add comma and 'see the' before link
  • Remove trailing whitespace after backslash in command-line example

Fixes #2357

Summary by CodeRabbit

  • Documentation
    • Updated configuration documentation with corrected default values
    • Standardized default values for configuration settings from "off" to "false"
    • Added SQLite documentation reference for enhanced clarity

✏️ Tip: You can customize this high-level summary in your review settings.

  - Change boolean defaults from 'off' to 'false' to match source
  code: lowercase, read_from_tail, strip_underscores
  - Fix grammar in db.sync description: add comma and 'see the'
  before link
  - Remove trailing whitespace after backslash in command-line
  example

Fixes fluent#2357

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell self-assigned this Jan 26, 2026
@eschabell eschabell requested a review from a team as a code owner January 26, 2026 13:02
@eschabell eschabell added waiting-on-review Waiting on a review from mainteners 5.0 labels Jan 26, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 26, 2026

📝 Walkthrough

Walkthrough

Updated systemd input plugin documentation by correcting boolean parameter defaults from off to false for lowercase, read_from_tail, and strip_underscores options, updating db.sync description with SQLite reference, and removing trailing whitespace.

Changes

Cohort / File(s) Summary
Systemd input documentation updates
pipeline/inputs/systemd.md
Changed defaults for 4 boolean configuration options from off to false (lowercase, read_from_tail, strip_underscores); updated db.sync description to reference SQLite docs; removed trailing whitespace from command-line example

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

4.2.1

Suggested reviewers

  • cosmo0920
  • patrick-stephens

Poem

🐰 Booleans were broken, off as they stood,
Now false, they flow better and good,
Systemd shines bright with defaults so true,
Docs cleaned and corrected—hop, hop, hooray to you!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: fixing incorrect boolean defaults, grammar issues, and whitespace problems in the systemd documentation.
Linked Issues check ✅ Passed All objectives from issue #2357 are met: boolean defaults corrected (off→false), grammar fixed in db.sync description, and whitespace removed from command-line example.
Out of Scope Changes check ✅ Passed All changes are directly related to the linked issue #2357 requirements: correcting defaults, fixing grammar, and removing whitespace in the systemd input plugin documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@pipeline/inputs/systemd.md`:
- Line 13: The documented defaults for the systemd input options are incorrect:
replace the boolean `false` values with the plugin's actual default `off` for
the options `lowercase`, `read_from_tail`, and `strip_underscores`; update the
table entries where `lowercase` (currently line 13), `read_from_tail` (line 17)
and `strip_underscores` (line 18) are shown as `false` to read `off` so the docs
match the Fluent Bit plugin behavior.

@patrick-stephens patrick-stephens merged commit e4717b4 into fluent:master Jan 26, 2026
8 checks passed
@eschabell eschabell removed the waiting-on-review Waiting on a review from mainteners label Jan 27, 2026
@eschabell eschabell deleted the erics_in_systemd_updates branch January 27, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Systemd input plugin doc needs updates

2 participants