-
Notifications
You must be signed in to change notification settings - Fork 545
docs: in_systemd: fix defaults, grammar, whitespace #2358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: in_systemd: fix defaults, grammar, whitespace #2358
Conversation
- Change boolean defaults from 'off' to 'false' to match source code: lowercase, read_from_tail, strip_underscores - Fix grammar in db.sync description: add comma and 'see the' before link - Remove trailing whitespace after backslash in command-line example Fixes fluent#2357 Signed-off-by: Eric D. Schabell <eric@schabell.org>
📝 WalkthroughWalkthroughUpdated systemd input plugin documentation by correcting boolean parameter defaults from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pipeline/inputs/systemd.md`:
- Line 13: The documented defaults for the systemd input options are incorrect:
replace the boolean `false` values with the plugin's actual default `off` for
the options `lowercase`, `read_from_tail`, and `strip_underscores`; update the
table entries where `lowercase` (currently line 13), `read_from_tail` (line 17)
and `strip_underscores` (line 18) are shown as `false` to read `off` so the docs
match the Fluent Bit plugin behavior.
Fixes #2357
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.