-
Notifications
You must be signed in to change notification settings - Fork 545
docs: in_syslog: fix descriptions and typos in config params #2356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughUpdated syslog input plugin documentation: clarified Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@pipeline/inputs/syslog.md`:
- Line 18: The description for the `port` field incorrectly uses “incoming
connections” which is misleading for UDP; update the documentation string that
mentions `port` and `mode` so it uses connectionless phrasing (e.g., “incoming
traffic/messages/packets” or “incoming messages/packets for UDP, connections for
TCP”) instead of “incoming connections” to accurately describe UDP behavior.
- Line 16: Update the grammar in the `parser` description so the clause reads
with a comma after "udp" and optionally remove the word "then" for clarity;
specifically edit the sentence that currently reads "If `mode` is set to `tcp`
or `udp` then the default parser is `syslog-rfc5424`." to "If `mode` is set to
`tcp` or `udp`, the default parser is `syslog-rfc5424`." in
pipeline/inputs/syslog.md where the `parser` table entry is defined.
- Rewrite buffer_chunk_size description for clarity - Fix "TCP port" to "port" (applies to both TCP and UDP modes) - Fix typo "OS-dependant" to "OS-dependent" - Add missing comma in parser description - Remove redundant "(set in code)" from buffer_chunk_size default Fixes fluent#2355 Signed-off-by: Eric D. Schabell <eric@schabell.org>
ed488c7 to
723315d
Compare
Fixes #2355
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.