Fix fedify init to include @fedify/vocab dependency #522
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After fedify-dev#517 extracted vocabulary classes into the separate @fedify/vocab package, projects created by fedify init were missing the @fedify/vocab dependency and importing Person from the wrong package. This commit fixes the issue by: - Adding @fedify/vocab to the default dependencies in getDependencies() - Updating the federation.ts template to import Person from @fedify/vocab instead of @fedify/fedify - Bumping @logtape/logtape version from ^1.1.0 to ^1.3.5 to match the version specified in the root deno.json
issues-auto-labeler
bot
added
component/build
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
2chanhaeng
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After PR #517 extracted vocabulary classes into the separate
@fedify/vocabpackage,fedify initwas still generating projects that only installed@fedify/fedifyand imported vocabulary types from the wrong package. This PR fixes the CLI to properly configure new projects with the correct dependencies and imports.Related issues
@fedify/fedifyinto@fedify/vocab#517Changes
@fedify/vocabto the default dependencies ingetDependencies()Personfrom@fedify/vocabinstead of@fedify/fedify@logtape/logtapeversion from^1.1.0to^1.3.5to match the version specified in the root deno.jsonBenefits
Projects created with
fedify initwill now:@fedify/vocabpackage as a dependencyChecklist
Did you add a changelog entry to the CHANGES.md?Did you write some relevant docs about this change (if it's a new feature)?Did you write a regression test to reproduce the bug (if it's a bug fix)?Did you write some tests for this change (if it's a new feature)?mise teston your machine?Additional notes
This is a bug fix for the CLI package that should be included in the next release to ensure that new projects created after the vocabulary extraction work correctly out of the box.