perf: optimize desktop app startup time #2644
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for howto-fix-macos-audio-selection canceled.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
Contributor
|
/staging |
|
Contributor
|
@ComputelessComputer please review if it work(no regression + faster startup) |
- Gate extension globals loading for iframe contexts only, deferring heavy UI component loading until actually needed by extensions - Change import.meta.glob from eager to lazy loading for UI components - Add loading spinner UI while store initializes instead of blank screen - Reduce window show sleep from 100ms to 10ms These changes should significantly reduce the ~2 second UI unresponsiveness on startup by: 1. Avoiding synchronous loading of all UI components at startup 2. Showing responsive UI immediately while store loads in background 3. Reducing artificial delay in window show Co-Authored-By: john@hyprnote.com <john@hyprnote.com>
Collaborator
i think this does reduce the overhead by 1~2 seconds but it is most definitely awful having a blank white screen on startup. opti.mp4 |
ComputelessComputer
force-pushed
the
devin/1767003523-optimize-startup-performance
branch
from
c1e4f37 to
1010474
Compare
ComputelessComputer
force-pushed
the
devin/1767003523-optimize-startup-performance
branch
from
1010474 to
68633a9
Compare
Collaborator
|
updated splash from spinner to skeleton |
ComputelessComputer
deleted the
devin/1767003523-optimize-startup-performance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses UI lag (~2 seconds of unresponsiveness) on desktop app startup by:
Lazy loading extension globals - Changed
import.meta.globfrom eager to lazy loading and only initialize extension globals for iframe/extension contexts. This defers heavy UI component loading until actually needed.Show loading UI immediately - Display a loading spinner while the TinyBase store initializes instead of rendering nothing (
null), making the app feel responsive immediately.Reduce window show delay - Decreased the hardcoded sleep in window show from 100ms to 10ms.
Review & Testing Checklist for Human
initExtensionGlobals()is now only called there and loads modules asynchronouslywindow.__hyprnoteor related globalsRecommended test plan:
Notes
show_asyncwith proper readiness signalingLink to Devin run: https://app.devin.ai/sessions/7c7cd7abf4134af2b9f6d813d18c9acd
Requested by: john@hyprnote.com (@ComputelessComputer)