feat(listener): emit error events for stream errors and timeouts #2215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Error variant to SessionEvent enum with session_id, error_type, message, and context fields
- Emit error events for WebSocket connection failures (timeout, connection failed)
- Emit error events for stream errors and timeouts
- Emit error events for audio device failures (mic/speaker open, stream setup, resample)
- Add emit_session_error helper function to reduce code duplication
- Use e.to_string() instead of format!("{:?}", e) for user-facing error context
This enables the UI to provide feedback on Actor status, so users know when
things like websocket connections fail due to wrong API keys or other issues.
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Resolved conflicts by adopting the new event structure: - SessionErrorEvent::ConnectionError for WebSocket errors - SessionErrorEvent::AudioError for audio device errors - Removed custom SessionEvent::Error variant - Fixed duplicate app field in SourceState Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
devin-ai-integration
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(listener): emit error events for stream errors and timeouts
Summary
Adds error event emissions for transcription stream errors and timeouts to enable UI feedback when actor errors occur. This allows the frontend to display meaningful error messages when WebSocket streams fail.
Changes:
SessionErrorEvent::ConnectionErrorforStreamErrorevents (withis_retryable: false)SessionErrorEvent::ConnectionErrorforStreamTimeoutevents (withis_retryable: false){}) instead of debug formatting ({:?}) for cleaner error messages in connection failuresUpdates since last revision
Resolved merge conflicts with main branch. The upstream had already introduced
SessionErrorEventwithConnectionErrorandAudioErrorvariants, so this PR now uses those existing event types rather than adding a customErrorvariant. Theemit_session_errorhelper function was removed in favor of using the upstream event structure directly.Review & Testing Checklist for Human
StreamErrorandStreamTimeoutshould surface to the frontendis_retryable: falseis correct - Stream errors/timeouts are marked as non-retryable; confirm this matches expected behaviorRecommended test plan:
SessionErrorEvent::ConnectionErrorwith the stream error detailsNotes
SourceStateis cosmetic (session_id before app) - no functional changeLink to Devin run: https://app.devin.ai/sessions/c2bf0e6b0059480ca52d1cb1f244502a
Requested by: yujonglee (@yujonglee)