Skip to content

Conversation

@stefannibrasil
Copy link
Contributor

@stefannibrasil stefannibrasil commented Jan 6, 2026

Motivation / Background

Closes #3146

Bumping Bundler version fixes the warnings when running the tests, which were a bunch. The remaining warnings when running the tests are generated from faker.

Additional information

Because Bundler's latest version does not support Ruby 3.0, I had to add the CI workaround until it is dropped. Commit messages provide more details for the additional Gemfile change.

We have one remaining warning on Ruby 4.0:

gems/i18n-1.14.7/lib/i18n/exceptions.rb:3: warning: CGI library is removed from Ruby 4.0. Please use cgi/escape instead for CGI.escape and CGI.unescape features.

But that is coming from i18n, and should be fixed next time dependabot bumps i18n to v1.14.8.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

@stefannibrasil stefannibrasil force-pushed the sb-warnings-ruby-4 branch 9 times, most recently from e88e993 to 42a52af Compare January 6, 2026 23:30
We are seeing a bunch of warnings when running the tests.
Bumping bundler's version fix them.

Because bundler's latest version does not support Ruby 3.0,
I had to add the CI workaround until 3.0 is not supported
anymore.
After bumping bundler's version, running a faker
console showed these warnings:

```
faker/Rakefile:12: warning: irb was loaded from
the standard library, but will no longer be part
of the default gems starting from Ruby 3.5.0.
You can add irb to your Gemfile or gemspec to silence this warning.
irb/input-method.rb:278: warning: rdoc was loaded
from the standard library, but will no longer be
part of the default gems starting from Ruby 3.5.0.
You can add rdoc to your Gemfile or gemspec to
silence this warning.
```
@stefannibrasil stefannibrasil marked this pull request as ready for review January 6, 2026 23:51
@stefannibrasil stefannibrasil merged commit 561862b into main Jan 7, 2026
8 checks passed
@stefannibrasil stefannibrasil deleted the sb-warnings-ruby-4 branch January 7, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix warnings on Ruby 4

3 participants