Check re-assignment of Final variables in less-common binding constructs
#1925
+94
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangyi-zhou
changed the title
Final variables in less-common binding constructs
This comment has been minimized.
This comment has been minimized.
yangdanny97
approved these changes
Dec 29, 2025
Contributor
yangdanny97
left a comment
yangdanny97
left a comment
There was a problem hiding this comment.
This LGTM, but I'll wait to import till after #1923 is merged
In this diff, we check for final annotations in unpacking assignments (e.g. when LHS is a tuple or list), and raise an error if a final variable is re-assigned. One fewer difference for conformance tests.
In this diff, we check whether the loop variable is marked final, and raise an error if that's the case. One fewer difference for conformance tests.
fangyi-zhou
force-pushed
the
final-reassignment-additional-checks
branch
from
90e81b9 to
1e42a87
Compare
Contributor
Author
|
Rebased |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this in D89935200. |
kinto0
approved these changes
Dec 30, 2025
Contributor
kinto0
left a comment
kinto0
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@yangdanny97 merged this pull request in cf29d5f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This diff extends existing re-assignment checks for variables declared as
Finalto a few other binding constructs that are less common (namely unpacking assignments, context manager assignments, and loop variable assignments). Overall, we have 3 more passing conformance test cases.Test Plan
python test.py