Skip to content

MAINT: fail on warnings #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
agoose77 merged 7 commits into from
Dec 5, 2024
Merged

MAINT: fail on warnings #647

agoose77 merged 7 commits into from
Dec 5, 2024

Conversation

@bsipocz
Copy link
Collaborator

@bsipocz bsipocz commented Nov 11, 2024

This should fix #645

@bsipocz
Copy link
Collaborator Author

bsipocz commented Nov 12, 2024

The configuration for failing on warnings is all OK, but the actual fix for the deprecation is a dead end currently as we run into a ModuleNotFoundError for the reader function we try to use it for.
However, there are some discussion upstream about the possible un-deprecation of it.

@bsipocz bsipocz added testing Additional testing to add dependencies Pull requests that update a dependency file labels Nov 12, 2024
@bsipocz
Copy link
Collaborator Author

bsipocz commented Nov 12, 2024

For context and recent discussion about the deprecation and possible un-deprecation see sphinx-doc/sphinx#13083

@bsipocz bsipocz force-pushed the TST_fail_on_warnings branch 4 times, most recently from 4605fe1 to 1b8a727 Compare November 16, 2024 09:15
@bsipocz
Copy link
Collaborator Author

bsipocz commented Nov 26, 2024

There are still tons of windows issues, and I have to rely on CI to get those sorted out, so I'm sorry for the upcoming flood of spammy notifications originating from this PR.

@bsipocz bsipocz force-pushed the TST_fail_on_warnings branch from 21f1877 to 816ea29 Compare November 26, 2024 12:13
@bsipocz
Copy link
Collaborator Author

bsipocz commented Nov 26, 2024

@agoose77 - This is good to go. I fully expect this to provide a lot of help with picking up the compatibility issues early on, the ones we run into now after users report them.

lucascolley
lucascolley approved these changes Dec 5, 2024
View reviewed changes
Copy link

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this looks good to me!

@agoose77
Copy link
Collaborator

agoose77 commented Dec 5, 2024

LGTM! Thanks @bsipocz and @lucascolley!

@agoose77 agoose77 merged commit 2cd6874 into executablebooks:master Dec 5, 2024
14 checks passed
@bsipocz bsipocz deleted the TST_fail_on_warnings branch December 5, 2024 16:07
@agriyakhetarpal
Copy link

agriyakhetarpal commented Dec 5, 2024

Thanks! Is there a release with this change planned soon? If there's any additional help I can provide on recent PRs, I'm happy to.

@mgeier mgeier mentioned this pull request Dec 24, 2024
Closed
@agriyakhetarpal agriyakhetarpal mentioned this pull request Jan 29, 2025
Merged
@agoose77 agoose77 changed the title TST: fail on warnings MAINT: fail on warnings Feb 20, 2025
@agoose77
Copy link
Collaborator

agoose77 commented Feb 20, 2025

@agriyakhetarpal there has since been a release! (1.2.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lucascolley lucascolley lucascolley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file testing Additional testing to add

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pending deprecation warning in Sphinx 8

4 participants

@bsipocz @agoose77 @agriyakhetarpal @lucascolley