Skip to content

Add picture to wikihover output #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wilding wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add picture to wikihover output #1

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
94bc05f
Feature: display image in popup window
wilding Feb 19, 2016
a50ff1b
Refactor: redistribute width spacing
wilding Mar 1, 2016
1e4ffc8
Refactor: show text-only output when no pictures are found
wilding Mar 31, 2016
4556756
Refactor: improve picture selection
wilding Mar 31, 2016
18974ac
Metadata: add comments
wilding Mar 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions src/inject/inject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ chrome.extension.sendMessage({}, function(response) {
{
//Clear the data
clearData();
//Remove the title attribute
//Remove the title attribute
element.removeAttr('title');

var baseURL = window.location.origin, //Get the URL
Expand All @@ -45,18 +45,38 @@ chrome.extension.sendMessage({}, function(response) {
$.get(fullURL, function(data) {
var content = $(data).find('#bodyContent').find('p').html(),
cssRules = {
position: 'fixed',
top: 10+"px",
left: 10+"px",
position: 'fixed',
top: 10+"px",
left: 10+"px",
right: 10+"px",
maxHeight: 500+"px",
padding: 1.4+"em",
background: "#fff",
boxShadow: "2px 2px 15px rgba(50,50,50,.75)",
zIndex: 100
};
// Select article pictures that are taller than 100px
var picture = $(data).find('#bodyContent').find('img').filter(function(index) {
return $(this).attr('height') > 100;
});
// Display popup with picture
if (picture.attr('src') !== undefined) {
var new_html = '';
new_html += '<div id="popup-notification" style="display: flex;">';
new_html += '<div style="margin-top: 10px; margin-bottom: 10px; padding-left: 10px; align-self: center;">';
new_html += content;
new_html += '</div>';
new_html += '<img src=';
new_html += picture.attr('src');
new_html += ' style="width: auto; max-height: 500px; margin: 0px; padding: 0px; margin-right: 10px;">';
new_html += '</div>';
new_html += '</div>';
$(new_html).css(cssRules).appendTo('body').fadeIn();
}
// If no picture exists, display text-only popup
else {
$('<div id="popup-notification" style="padding: 10px;">'+content+'</div>').css(cssRules).appendTo('body').fadeIn();
}

$('<div id="popup-notification">'+content+'</div>').css(cssRules).appendTo('body').fadeIn();
});
}
}
Expand Down