-
Notifications
You must be signed in to change notification settings - Fork 3.5k
CI: Move license compliance to its own file #14982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Move license compliance to its own file #14982
Conversation
|
@eksperimental This action also checks the license headers of any other file a PR author touches. I recommend to run it for each PR. |
|
👍 for moving it out but we most likely always want to run this, as mentioned by @maennchen. |
|
updated |
|
@eksperimental please rebase and we can ship it! Thank you! |
|
@eksperimental ping :) |
|
Sorry, I have been super busy. I will take care of it today. Thank you for the reminder @josevalim |
|
@eksperimental take your time, I just wanted to make sure it did not fell through the cracks. Or if you give me permission to change your branch, I can do it. :) |
|
Done. Can we run the tests to make sure the CI passes? |
|
💚 💙 💜 💛 ❤️ |
The most critical changes is when the action is launched.
This is the action that takes the longest to complete (longer than 8 minutes). I think we can avoid running this action every time when a PR is submitted and run it only when the files that modify this action are modified, and when it merged to the main branch.
/cc @maennchen