chore: add enterprise-catalog in devstack #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huniafatima-99
force-pushed
the
huniafatima/add-enterprise-catalog-in-devstack
branch
from
5d90f7a to
7678187
Compare
huniafatima-99
force-pushed
the
huniafatima/add-enterprise-catalog-in-devstack
branch
from
54705a2 to
343b4cd
Compare
Contributor
iamsobanjaved
left a comment
iamsobanjaved
left a comment
There was a problem hiding this comment.
Few more changes, also you need to rebase it correctly with main branch as it is currently also including the changes from master.
huniafatima-99
force-pushed
the
huniafatima/add-enterprise-catalog-in-devstack
branch
from
343b4cd to
9105836
Compare
iamsobanjaved
approved these changes
Jan 1, 2025
Contributor
iamsobanjaved
left a comment
iamsobanjaved
left a comment
There was a problem hiding this comment.
Just one change, rest 👍
Makefile
Outdated
Comment on lines
410
to
412
| dev.shell.enterprise-catalog: | ||
| docker exec -it edx.devstack.enterprise-catalog env TERM=$(TERM) bash -c '/bin/bash' | ||
|
|
Contributor
There was a problem hiding this comment.
Revert this change as this will be handled by dev.shell.% target.
Makefile
Outdated
Comment on lines
410
to
412
| dev.shell.enterprise-catalog: | ||
| docker exec -it edx.devstack.enterprise-catalog env TERM=$(TERM) bash -c '/bin/bash' | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| dev.shell.enterprise-catalog: | |
| docker exec -it edx.devstack.enterprise-catalog env TERM=$(TERM) bash -c '/bin/bash' |
suggestion for commit
huniafatima-99
force-pushed
the
huniafatima/add-enterprise-catalog-in-devstack
branch
from
0a17398 to
09c7fde
Compare
huniafatima-99
deleted the
huniafatima/add-enterprise-catalog-in-devstack
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.