N&N for ImageDataAtSizeProvider being referencable #465
+47
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merks
requested changes
Dec 31, 2025
Contributor
merks
left a comment
merks
left a comment
There was a problem hiding this comment.
It generally looks good. Just a few small/simple changes...
arunjose696
force-pushed
the
arunjose696/N
branch
from
be1da2b to
599e9bd
Compare
merks
approved these changes
Dec 31, 2025
HeikoKlare
force-pushed
the
arunjose696/N
branch
2 times, most recently
from
7c07f32 to
a52c793
Compare
HeikoKlare
approved these changes
Jan 5, 2026
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Thank you for writing the news entry.
I have added a paragraph on the possibility to also use the provider for retrieving image handles/data based on zoom via the getDefaultSize() method.
And I have added a reference to the news on the addition of the GC.drawimage(Image, int, int, int, int) method, so that reader can easily find the information on that method that is needed to make proper use of that provider.
HeikoKlare
force-pushed
the
arunjose696/N
branch
from
a52c793 to
aa9aff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding N&N entry. To be meged after eclipse-platform/eclipse.platform.swt#2922