Removing usages of Display#getDPI from test #2869
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Contributor
HeikoKlare
requested changes
Dec 29, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Having the scale factor being based on the screen DPI leads to unexpected result e.g. Image too big/small. Having a screen dpi independent factor leads to consistent results
I do not understand how the commit/PR message is related to the actual change. There is no change in what DPI value is used at all. The change simply adds a faulty warning suppression and removes some text.
....swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Display.java
Outdated
Show resolved
Hide resolved
ShahzaibIbrahim
force-pushed
the
master-224-test
branch
2 times, most recently
from
9c6eff8 to
ed1c3a9
Compare
Contributor
Author
|
Updated the message in PR and commit. SuppressWarning was added to test as Display#getDPI is set to be deprecated but it does make sense to do it when it is actually deprecated. |
Contributor
This commit is made to prepare for Display#getDPI deprecation. removing/replacing all unnecessary usages.
ShahzaibIbrahim
force-pushed
the
master-224-test
branch
from
ed1c3a9 to
fa03ab0
Compare
HeikoKlare
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is made to prepare for Display#getDPI deprecation. removing/replacing all unnecessary usages.