Skip to content

Conversation

@Danipiza
Copy link
Contributor

@Danipiza Danipiza commented Jan 16, 2026

Added new function:

std::vector<std::string> join_quoted_strings(
        const std::vector<std::string>& input);

This function is used in read_next_command(Command<CommandEnum>& command) to join quotes in a single argument. Used in FastDDS-Spy filter by topic (Content Filtered Topic)

Example

// command = filter set topic HelloWorldTopic "index > 10" 

Before: ["filter", "set", "topic", "HelloWorldTopic", "\"index", ">", "10\"" ] // Size: 7
After:  ["filter", "set", "topic", "HelloWorldTopic", "index > 10" ] // Size: 5

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.30%. Comparing base (fd0f9f5) to head (87b8812).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...de/cpp_utils/user_interface/impl/CommandReader.ipp 33.33% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   60.59%   60.30%   -0.30%     
==========================================
  Files          65       65              
  Lines        1921     1932      +11     
  Branches      543      551       +8     
==========================================
+ Hits         1164     1165       +1     
- Misses        437      445       +8     
- Partials      320      322       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants