Skip to content

Conversation

@GangGreenTemperTatum
Copy link
Collaborator

@GangGreenTemperTatum GangGreenTemperTatum commented Jan 16, 2025

closes #12

Changes made:

  1. Added a "Follow Redirects" checkbox to the scanner UI
  2. Enhanced the URL analysis to handle redirect behavior based on checkbox state
  3. Added redirect information to the security analysis output
  4. Improved error handling to capture redirect status codes when not following redirects

enabled by default 👌

image

AI-Generated Summary

PR Summary

Overview of Changes

Arr mateys, this be a tale of codin' and sailin' through the treacherous seas of the burpference/scanner.py. Our crew 'ave made some crafty enhancements and bug fixes, they did. With nary a worry for breakin' things that weren't meant to be tampered with, the hearties introduced a JCheckBox for followin' redirects, restructured how HTTP requests handle these redirects, and improved error handlin'. These changes be aimed at makin' the HTTP request process more flexible and informative, especially when sailin' through the HTTP seas with or without choosin' to follow redirects.

Key Modifications

  1. Added Follow Redirects Checkbox: By the code, a new JCheckBox "Follow Redirects" has been added, allowing the user to decide whether to trail after HTTP redirects automatically. The checkbox comes checked by default, blendin' with the dark theme of the UI.
  2. Reengineered HTTP Request Handling: The procedure for makin' HTTP requests has been overhauled with the use of an urllib2.build_opener() to manage redirects based on the state of the newly introduced checkbox. This modification allows for a more controlled navigatin' experience through the vast, uncertain waters of the HTTP protocol.
  3. Enhanced Error and Redirect Handling: The application now gracefully handles HTTP errors and redirects, by catchin' urllib2.HTTPError exceptions and includin' additional information in the security_info dictionary such as the initial URL, final URL, and whether a redirect occurred.

Potential Impact

  • The introduction of redirect choice may change the behavior of existing scan workflows, particularly for those who were expectin' an automatic follow-through of redirects without explicitly optin' in or out.
  • The improved error and redirect reporting enhances the transparency of the scanning process and could be crucial for diagnosing issues with specific URLs, but it may also result in more detailed output that needs to be considered in analysis workflows.
  • Modifications to HTTP request handlin' and error reportin' might affect the performance characteristics of scans, potentially leadin' to longer scan times for URLs with multiple redirects or error states.

This summary was generated with ❤️ by rigging

@GangGreenTemperTatum GangGreenTemperTatum merged commit 68bfeb3 into main Jan 16, 2025
2 checks passed
@GangGreenTemperTatum GangGreenTemperTatum deleted the ads/eng-815-burpference-scanner-follow-re-directs-in-the-burpference branch January 16, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Follow re-directs in the burpference scanner

2 participants