Fix entity accessibility in EF Core Keys examples — use public instead of internal #5217
+10
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EF Core documentation for Keys
Currently shows example entity classes declared as internal.
Using internal limits the entity to the same assembly, which can be confusing, because entities are typically accessed from other parts of an application such as controllers, services, or unit tests.
This PR updates the examples to use public for entity classes, which is the recommended practice in real-world applications and better standard EF Core usage.
// Before
internal class Car
{
public string Id { get; set; }
public string Make { get; set; }
public string Model { get; set; }
}
// After
public class Car
{
public string Id { get; set; }
public string Make { get; set; }
public string Model { get; set; }
}
No functional changes are made.
This is a documentation improvement for clarity and correctness.